Refactor `tigase.xmpp.impl.ServiceDiscovery` plugin to make it extensible (#1554)

Wojciech Kapcia (Tigase) opened 1 year ago

Currently, ServiceDiscovery plugin relies on injecting tigase.xmpp.impl.ServiceDiscovery.AccountServiceProvider (only PEP from tigase-pubsub supports it) and if it is present it forwards query to the PEP plugin/pubsub for processing.

It would be better to make the logic extensible and allow creating multiple provider implementations and call them to add particular features to service discovery and combine the result in one request. It would simplify the processing logic and give us more flexibility.

Activities

Wojciech Kapcia (Tigase) added "Related" Customers/atom#184 1 year ago
Andrzej Wójcik (Tigase) commented 1 week ago

PEP processor forwards it for processing to PubSub component as only PubSub component is aware of the features that are available currently for particular JID/account. Due to that, it would be hard to embed it in processor extension without exposing PubSub component to the processor (possibly forcing requests on the PubSub repository from the sess-man threads).
Wojciech Kapcia (Tigase) commented 1 week ago

I was thinking of having something akin to tigase.vhosts.VHostItemExtensionIfc. Alas, while it would be nice to have extensible ServiceDiscovery I'm not sure if it's that important (especially for 8.5.0).

Should we push it to "Next major version"?
Andrzej Wójcik (Tigase) commented 1 week ago

I think, if we would need to make it more extensible, then it would be better to push it to the next version.
Wojciech Kapcia (Tigase) added to iteration "Candidate for next major release" 1 week ago
Wojciech Kapcia (Tigase) removed from iteration "tigase-server-8.5.0" 1 week ago
Wojciech Kapcia (Tigase) changed fields 1 week ago
Name Previous Value Current Value
Version

8.5.0
empty
Login to comment

Name	Previous Value	Current Value
Version	8.5.0	empty

Type	Improvement
Priority	If you are bored
Assignee	Wojciech Kapcia (Tigase)
Version	none
Sprints	n/a
Customer	n/a

Iterations

Candidate for next major release Open

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/server-core#1554