server-to-client ping result causes server error: "bad-request" (#1552)

Wojciech Kapcia (Tigase) opened 1 year ago

Connection Watchdog periodically sends XMPP pings and the result response from client is not handled correctly

S: <iq from="chat4.im" to="wojtek@chat4.im/atlantiscity" type="get" id="tigase-ping">
<ping xmlns="urn:xmpp:ping"/>
</iq>

C: <iq to="chat4.im" type="result" id="tigase-ping"/>

S: <iq from="chat4.im" to="wojtek@chat4.im/atlantiscity" type="error" id="tigase-ping">
<error code="400" type="modify">
<bad-request xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
<text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas" xml:lang="en">XMPP error condition: bad-request </text>
</error>
</iq>

Captura de pantalla 2025-01-02 a las 9.31.07.png

Spec: https://xmpp.org/extensions/xep-0199.html#s2c

Related
- Retract notification from MIX should remove MIX channel from the roster (tigase/_server/tigase-mix#43) In Progress

Activities

Andrzej Wójcik (Tigase) added "Related" tigase/_server/tigase-mix#43 2 weeks ago
Andrzej Wójcik (Tigase) commented 2 weeks ago

This issue was caused by change created in tigase/_server/tigase-mix#43. Feature to test if stanze has element on specified path with any xmlns actually tested positive for any stanza, even if it had no element at specified path.

That could create additional load on the server and could cause performance issues, so I've resolved it and that also resolved the issue with error being sent back to the client.
Andrzej Wójcik (Tigase) changed state to 'In QA' 2 weeks ago
Previous Value Current Value
Open

In QA
Wojciech Kapcia (Tigase) changed state to 'Closed' 2 weeks ago
Previous Value Current Value
In QA

Closed
Login to comment

Previous Value	Current Value
Open	In QA

Previous Value	Current Value
In QA	Closed

Type	Bug
Priority	If you are bored
Assignee	Wojciech Kapcia (Tigase)
Version	none
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.5.0 Open

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/server-core#1552